Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support BLS12-381 (based on bls12_381 crate) #8

Merged
merged 27 commits into from
Jan 25, 2024

Conversation

nulltea
Copy link

@nulltea nulltea commented Oct 2, 2023

Add curve BLS12-381. Targets ff = "0.13.0".

Sources:

The decision to copy implementation from bls12_381 crate is explained by the numerous additional trait impls needed to be compatible with halo2-lib. See bellow.

Additional changes

@jonathanpwang
Copy link

Thanks for this!
Will review it soon (and then your halo2-lib PRs).

@jonathanpwang jonathanpwang changed the base branch from main to feat/bls12_381 January 2, 2024 14:08
src/bls12_381/fp6.rs Outdated Show resolved Hide resolved
Copy link

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to the necessity of some prime field traits on fp2, request to at least put in the correct constants when possible. After that good to merge.

src/bls12_381/fp2.rs Show resolved Hide resolved
src/bls12_381/fp2.rs Show resolved Hide resolved
src/bls12_381/fp2.rs Show resolved Hide resolved
src/bls12_381/fp2.rs Outdated Show resolved Hide resolved
@jonathanpwang jonathanpwang changed the base branch from feat/bls12_381 to main January 24, 2024 17:16
Copy link

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after updating sha2 and digest import versions

@jonathanpwang jonathanpwang merged commit b7b6525 into axiom-crypto:main Jan 25, 2024
7 checks passed
@jonathanpwang jonathanpwang mentioned this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants